Re: [pgAdmin4][Patch]: RM #1801 : Properly handle databases with datallowconn == false

Hi,

Please find the attached updated patch.

On Fri, Nov 18, 2016 at 7:45 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:

> Hi
>
> On Fri, Nov 18, 2016 at 1:03 PM, Khushboo Vashi
> <khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
> > Hi,
> >
> > Please find the attached patch for RM #1801: Properly handle databases
> with
> > datallowconn == false.
> >
> > Issue: While connecting the database, allowconn parameter was not in
> > consideration. Also, the database properties query call was on the
> selected
> > database which was not correct.
> >
> > Fix: Put the check of allowconn, while connecting the database in JS
> file.
> > Also, the database properties query call set to the maintenance database.
>
> All good, but this is just infrastructure for what's really required;
> i.e. disabling menu options to do things like backups, run the query
> tool etc. (anything that needs a connection). Can you resolve that
> please?
>
>
Fixed

> Thanks.
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>