Re: [pgAdmin4][Patch]: RM #1801 : Properly handle databases with datallowconn == false

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][Patch]: RM #1801 : Properly handle databases with datallowconn == false
Date: 2016-11-18 14:15:41
Message-ID: CA+OCxowuUzo1dWeRRya-CY23ddybNnptudBm5Yuvz66uGK2DkQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi

On Fri, Nov 18, 2016 at 1:03 PM, Khushboo Vashi
<khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
> Hi,
>
> Please find the attached patch for RM #1801: Properly handle databases with
> datallowconn == false.
>
> Issue: While connecting the database, allowconn parameter was not in
> consideration. Also, the database properties query call was on the selected
> database which was not correct.
>
> Fix: Put the check of allowconn, while connecting the database in JS file.
> Also, the database properties query call set to the maintenance database.

All good, but this is just infrastructure for what's really required;
i.e. disabling menu options to do things like backups, run the query
tool etc. (anything that needs a connection). Can you resolve that
please?

Thanks.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2016-11-18 14:24:20 pgAdmin 4 commit: Render column headers at the correct width in the que
Previous Message Dave Page 2016-11-18 14:05:56 Re: [pgAdmin4][Patch]: RM #1855