Re: [pgAdmin4][Pattch] - RM #3673 - "Download as .csv" F8 does NOT work when one of joined files is a TEMPORARY file

From: Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][Pattch] - RM #3673 - "Download as .csv" F8 does NOT work when one of joined files is a TEMPORARY file
Date: 2019-02-18 09:08:03
Message-ID: CAFOhELcidmC5w_KAeP-mjB4jiFBcHSBWspHyr=zsbPBzGLmKGA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

On Thu, Feb 14, 2019 at 4:12 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:

> Hi
>
> On Thu, Feb 14, 2019 at 6:56 AM Khushboo Vashi
> <khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
> >
> > Hi,
> >
> > Please find the attached patch to fix the RM #3673 - "Download as .csv"
> F8 does NOT work when one of joined files is a TEMPORARY file
> >
> > To fix this issue, used the existing query tool connection instead of a
> new connection to download the CSV file.
>
> That side of it seems to work well, however, I can still attempt to
> execute queries in the tool whilst it's running. We need to display
> the same gray screen with the spinner whilst a CSV download is
> executing as we do when a normal query is executing. We also need to
> ensure the button bar behaves appropriately - e.g. the execute options
> should be disabled, the cancel button should be enabled etc.
>
> We use an iframe to download the CSV file. So, after attaching the proper
URL to the iframe, the browser handles the download part.
So, the main problem is catching the event after the download completes.

Any suggestion?

>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2019-02-18 09:38:47 Re: [pgAdmin4][Pattch] - RM #3673 - "Download as .csv" F8 does NOT work when one of joined files is a TEMPORARY file
Previous Message Dave Page 2019-02-15 15:44:54 pgAdmin 4 commit: Add a "scratch pad" to the Query Tool to hold text sn