| From: | Dave Page <dpage(at)pgadmin(dot)org> |
|---|---|
| To: | Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com> |
| Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: [pgAdmin4][Pattch] - RM #3673 - "Download as .csv" F8 does NOT work when one of joined files is a TEMPORARY file |
| Date: | 2019-02-14 10:42:14 |
| Message-ID: | CA+OCxoyqRLUBMBMY00XrhTu1zdGtEiS-jSSwboyyirrymoYj6Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi
On Thu, Feb 14, 2019 at 6:56 AM Khushboo Vashi
<khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>
> Hi,
>
> Please find the attached patch to fix the RM #3673 - "Download as .csv" F8 does NOT work when one of joined files is a TEMPORARY file
>
> To fix this issue, used the existing query tool connection instead of a new connection to download the CSV file.
That side of it seems to work well, however, I can still attempt to
execute queries in the tool whilst it's running. We need to display
the same gray screen with the spinner whilst a CSV download is
executing as we do when a normal query is executing. We also need to
ensure the button bar behaves appropriately - e.g. the execute options
should be disabled, the cancel button should be enabled etc.
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dave Page | 2019-02-14 11:15:05 | pgAdmin 4 commit: Optimise display of Dependencies and Dependents, and |
| Previous Message | pgAdmin 4 Jenkins | 2019-02-14 10:29:48 | Jenkins build is back to normal : pgadmin4-master-python27 #938 |