Re: [pgAdmin4][Patch]: RM #1513 - Unable to do max selection to drop tables/sequences/functions

Hi,

Please find the attached updated patch with the fixes.

Thanks,
Khushboo

On Fri, Sep 21, 2018 at 3:27 PM Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
wrote:

> Hi Khushboo
>
> Following are my review comments (GUI):
>
> - Fix PEP8 warnings.
> - Delete/Drop and Drop Cascade menu should not be enabled if none of
> the object is selected.
> - Dialog title "DROP Multiple ?" and "DROP Cascade Multiple ?" should
> be changed. Even if I select only one object title shows "DROP Multiple ?".
> - Drop Cascade menu should not be there for *pgAgent Jobs* node. When
> try to delete/drop it throws "Method not allowed" error message.
> - Getting invalid input syntax error when try to delete/drop
> *TableSpaces.*
> - This feature should not be applicable to *Catalogs* and all there
> child nodes.
> - Wrong error message displayed when delete/drop 'plpgsql' *Language. *It
> throws "can't execute an empty query" instead of error message comes from
> the database server.
> - Wrong error message displayed when delete/drop *Foreign Data
> Wrappers. *It throws "can't execute an empty query" instead of error
> message comes from the database server.
> - Getting syntax error when try to delete/drop *Resource Groups* for
> EPAS servers.
> - Getting "Method not allowed" error for functions, procedures and
> variables inside the *Packages* node.
>
> I am unable to test for some of the nodes. I have not review source code.
>
> On Fri, Sep 21, 2018 at 11:14 AM Khushboo Vashi <
> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>
>> Hi,
>>
>> Please find the patch for RM #1513 - Unable to do max selection to drop
>> tables/sequences/functions.
>>
>> - Added Drop and Drop cascade options for the collection nodes on the
>> properties tab.
>> - Added the API test cases for the collection nodes to check the multiple
>> delete.
>> - Table Constraints module has been excluded currently as we need some
>> totally different implementation for that.
>>
>> Thanks,
>> Khushboo
>>
>
>
> --
> *Akshay Joshi*
>
> *Sr. Software Architect *
>
>
>
> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>