Re: Build failed in Jenkins: pgadmin4-master-python33 #507

On Wed, Mar 7, 2018 at 9:23 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:

> Hi
>
> On Wed, Mar 7, 2018 at 3:10 PM, Khushboo Vashi <
> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>
>> Hi Dave,
>>
>> On Wed, Mar 7, 2018 at 7:34 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>
>>> Khushboo, can you look at this ASAP please? It passed tests on my
>>> machine, but Jenkins isn't happy.
>>>
>>> I have tried to reproduce the issue with many combination but couldn't
>> reproduce it.
>> With the help of logs, I have tried to fix it. Can you please check this
>> fix is helpful or not?
>>
>
> On my laptop I now get:
>
> ======================================================================
> ERROR: runTest (pgadmin.tools.sqleditor.tests.test_poll_query_tool.
> TestPollQueryTool)
> When query tool polling returns messages with result data-set
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File "/Users/dpage/git/pgadmin4/web/pgadmin/tools/sqleditor/
> tests/test_poll_query_tool.py", line 104, in runTest
> response_data['data']['additional_messages'])
> File "/System/Library/Frameworks/Python.framework/Versions/2.7/
> lib/python2.7/unittest/case.py", line 802, in assertIn
> if member not in container:
> TypeError: argument of type 'NoneType' is not iterable
>
> ----------------------------------------------------------------------
>
> Please provide some more details. Is this failing for particular server
version?
I am not getting any error with this patch and without this patch on PY2
and PY3 with a single/multiple servers.

> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>