Re: Build failed in Jenkins: pgadmin4-master-python33 #507

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Build failed in Jenkins: pgadmin4-master-python33 #507
Date: 2018-03-07 15:53:00
Message-ID: CA+OCxoziegBKj165ysM86fWL3m1CFN5+hnVBDjx3D9eeFHH6=Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi

On Wed, Mar 7, 2018 at 3:10 PM, Khushboo Vashi <
khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:

> Hi Dave,
>
> On Wed, Mar 7, 2018 at 7:34 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>> Khushboo, can you look at this ASAP please? It passed tests on my
>> machine, but Jenkins isn't happy.
>>
>> I have tried to reproduce the issue with many combination but couldn't
> reproduce it.
> With the help of logs, I have tried to fix it. Can you please check this
> fix is helpful or not?
>

On my laptop I now get:

======================================================================
ERROR: runTest
(pgadmin.tools.sqleditor.tests.test_poll_query_tool.TestPollQueryTool)
When query tool polling returns messages with result data-set
----------------------------------------------------------------------
Traceback (most recent call last):
File
"/Users/dpage/git/pgadmin4/web/pgadmin/tools/sqleditor/tests/test_poll_query_tool.py",
line 104, in runTest
response_data['data']['additional_messages'])
File
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/unittest/case.py",
line 802, in assertIn
if member not in container:
TypeError: argument of type 'NoneType' is not iterable

----------------------------------------------------------------------

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2018-03-07 16:01:10 pgAdmin 4 commit: Update Jasmine to v3. Fixes #3182
Previous Message Murtuza Zabuawala 2018-03-07 15:17:58 Re: [pgAdmin4][RM#3037] Allow user to disable Gravatar image