Re: Extra functionality to createuser

From: Christopher Browne <cbbrowne(at)gmail(dot)com>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: Sameer Thakur <samthakur74(at)gmail(dot)com>, PostgreSQL Mailing Lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Extra functionality to createuser
Date: 2013-11-15 23:27:18
Message-ID: CAFNqd5XBiNq_WUwtcPci7QVNm8j3rfqhQ-5giWLT0THKa=HaOw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Nov 15, 2013 at 3:14 PM, Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:
> On 11/14/13, 4:35 PM, Christopher Browne wrote:> On Thu, Nov 14, 2013 at
> 5:41 AM, Sameer Thakur <samthakur74(at)gmail(dot)com> wrote:
>>> So i think -g option is failing
>>
>> Right you are.
>>
>> I was missing a "g:" in the getopt_long() call.
>>
>> Attached is a revised patch that handles that.
>>
>
> src/bin/scripts/createuser.c:117: indent with spaces.
> + case 'g':
> src/bin/scripts/createuser.c:118: indent with spaces.
> + roles = pg_strdup(optarg);

OK, I ran pgindent on createuser.c, which leads to the Next Patch...

--
When confronted by a difficult problem, solve it by reducing it to the
question, "How would the Lone Ranger handle this?"

Attachment Content-Type Size
createuser2.diff text/plain 2.6 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2013-11-15 23:38:00 Re: Improve code in tidbitmap.c
Previous Message Peter Geoghegan 2013-11-15 23:23:58 Re: autovacuum_work_mem