Re: Why we need to check for local buffers in BufferIsExclusiveLocked and BufferIsDirty?

On Sun, Jan 26, 2025 at 9:49 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:

> Srinath Reddy <srinath2133(at)gmail(dot)com> writes:
> > as suggested did the changes and attached the patch for the same.
>
> Uh ... what in the world is the point of changing
> BufferIsExclusiveLocked's signature?
>
> regards, tom lane
>

as there was repeated code between BufferIsExclusiveLocked and
BufferIsDirty to check if buffer is pinned and its locked exclusively,i
thought it would be nice to move that repeated code into
BufferIsExclusiveLocked and as we need bufHdr in BufferIsDirty which is
assigned in BufferIsExclusiveLocked,so I had to change the signature of
BufferIsExclusiveLocked by adding (BufferDesc **bufHdr).

Regards,
Srinath Reddy Sadipiralla,
EDB: http://www.enterprisedb.com