| From: | John Naylor <john(dot)naylor(at)enterprisedb(dot)com> |
|---|---|
| To: | Richard Guo <guofenglinux(at)gmail(dot)com> |
| Cc: | Japin Li <japinli(at)hotmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Typo in pg_db_role_setting.h |
| Date: | 2022-08-02 04:13:25 |
| Message-ID: | CAFBsxsFuZQvd7CW_bNqOZESmwqfLYZid=MSbhE_hAgXhueAwMg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Aug 2, 2022 at 10:06 AM Richard Guo <guofenglinux(at)gmail(dot)com> wrote:
>
> I'm not sure that we should remove such comments. And a rough search
> shows that there are much more places with this kind of comments, such
> as below:
>
> nbtxlog transam readfuncs walreceiver buffile bufmgr fd latch pmsignal
> procsignal sinvaladt logtape rangetypes
I was talking only about catalog/pg_*.c functions, as in Japin Li's latest
patch. You didn't mention whether your examples fall in the category Tom
mentioned upthread, so I'm not sure what your angle is.
--
John Naylor
EDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2022-08-02 04:29:33 | Re: allow building trusted languages without the untrusted versions |
| Previous Message | houzj.fnst@fujitsu.com | 2022-08-02 03:20:55 | RE: Support logical replication of DDLs |