Re: contrib/spi/insert_username.c comment typo?

From: John Naylor <john(dot)naylor(at)enterprisedb(dot)com>
To: jian he <jian(dot)universality(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: contrib/spi/insert_username.c comment typo?
Date: 2023-05-29 04:43:13
Message-ID: CAFBsxsEtAbZ6XKNYK2BwWBv-JWdYA3FeD-07Tc=zAtHpcRh_0w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, May 29, 2023 at 11:31 AM jian he <jian(dot)universality(at)gmail(dot)com>
wrote:
> hi.
> reading through contrib/spi/insert_username.c
>
https://git.postgresql.org/gitweb/?p=postgresql.git;a=blob;f=contrib/spi/insert_username.c;h=a2e1747ff74c7667665dcc334f54ad368885d83c;hb=HEAD
> 36 /* sanity checks from autoinc.c */
> 37 if (!CALLED_AS_TRIGGER(fcinfo))
> 38 /* internal error */
> 39 elog(ERROR, "insert_username: not fired by trigger manager");
>
> should it be /* sanity checks from insert_username.c */ ?

I believe it's saying the checks were copied from autoinc.c.

--
John Naylor
EDB: http://www.enterprisedb.com

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2023-05-29 05:38:00 Re: Docs: Encourage strong server verification with SCRAM
Previous Message jian he 2023-05-29 04:31:37 contrib/spi/insert_username.c comment typo?