Re: ECPG: WHENEVER statement with DO CONTINUE action

From: Vinayak Pokale <vinpokale(at)gmail(dot)com>
To: Michael Meskes <meskes(at)postgresql(dot)org>
Cc: vinayak <Pokale_Vinayak_q3(at)lab(dot)ntt(dot)co(dot)jp>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: ECPG: WHENEVER statement with DO CONTINUE action
Date: 2017-06-10 03:23:33
Message-ID: CAEySZvgDHTMVhcs9hUNz9UBgR32a_mSC3aK0eZ8yOW2uSnQfGA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Thank you for your reply

On Jun 9, 2017 5:39 PM, "Michael Meskes" <meskes(at)postgresql(dot)org> wrote:
>
> Hi,
>
> > To develop the ECPG application more efficiently and improve
> > portability,
> > I would like to suggest one minor improvement "WHENEVER condition DO
> > CONTINUE" support in ECPG.
> > Oracle Pro*C supports WHENEVER statement with DO CONTINUE action.[1]
> >
> > EXEC SQL WHENEVER SQLERROR CONTINUE;
> > is not same as
> > EXEC SQL WHENEVER SQLERROR DO CONTINUE;
> >
> > The CONTINUE action instructs the client application to proceed to
> > the next statement whereas DO CONTINUE action instructs the client
> > application to emit a C continue statement and the flow of control
> > return to the beginning of the enclosing loop.
>
> This did actual escape me. Thanks for bringing it to our attention and
> fixing this missing functionality.
>
> > I have tried to implement it. Please check the attached patch.
> > Please give me feedback.
> > ...
>
> Could you please add a "DO CONTINUE" case to one of the test cases? Or
> add a new one? We would need a test case IMO.
>
Yes I will add test case and send updated patch.

Regards,
Vinayak Pokale

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Masahiko Sawada 2017-06-10 05:20:58 Re: logical replication: \dRp+ and "for all tables"
Previous Message Greg Stark 2017-06-10 02:54:03 Re: Notes on testing Postgres 10b1