| From: | Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com> |
|---|---|
| To: | jian he <jian(dot)universality(at)gmail(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Subject: | Re: two occurrences of assign print_notnull within pg_dump.c |
| Date: | 2025-04-03 11:22:08 |
| Message-ID: | CAExHW5uqAmY74aONmW0ax58AfBKXmt9jrj88D2jPxy-jD2fAkw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Apr 3, 2025 at 4:31 PM jian he <jian(dot)universality(at)gmail(dot)com> wrote:
>
> hi.
>
> in src/bin/pg_dump/pg_dump.c
> within function dumpTableSchema:
> there are two occurrences of:
> print_notnull = (tbinfo->notnull_constrs[j] != NULL &&
> (tbinfo->notnull_islocal[j] ||
> dopt->binary_upgrade ||
> tbinfo->ispartition));
The same commit 14e87ffa5c543b5f30ead7413084c25f7735039f modified
existing definition of print_notnull and added another. I wonder why.
- probably just an oversight or define to closer to usage. But we
don't do the latter.
--
Best Wishes,
Ashutosh Bapat
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2025-04-03 11:29:21 | Re: Make query cancellation keys longer |
| Previous Message | Heikki Linnakangas | 2025-04-03 11:13:38 | Re: [PATCH] Add sortsupport for range types and btree_gist |