two occurrences of assign print_notnull within pg_dump.c

From: jian he <jian(dot)universality(at)gmail(dot)com>
To: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Cc: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Subject: two occurrences of assign print_notnull within pg_dump.c
Date: 2025-04-03 11:00:47
Message-ID: CACJufxFqckBFxPfCixHHbOr0zMLksviTj2m3o12-tErfx_PvTg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

hi.

in src/bin/pg_dump/pg_dump.c
within function dumpTableSchema:
there are two occurrences of:
print_notnull = (tbinfo->notnull_constrs[j] != NULL &&
(tbinfo->notnull_islocal[j] ||
dopt->binary_upgrade ||
tbinfo->ispartition));

we can delete the second one.
to confirm delete the second is fine.
I did run a test, and all tests are OK.

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Sandeep Thakkar 2025-04-03 11:02:25 Re: Making sslrootcert=system work on Windows psql
Previous Message Daniel Gustafsson 2025-04-03 10:41:35 Re: Making sslrootcert=system work on Windows psql