From: | Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com> |
---|---|
To: | Michael Paquier <michael(at)paquier(dot)xyz> |
Cc: | Steve Chavez <steve(at)supabase(dot)io>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [PATCH] clarify palloc comment on quote_literal_cstr |
Date: | 2025-04-08 08:26:46 |
Message-ID: | CAExHW5uE8ZzfoGecZs0M0FgxQLMydtro5vF_BEh-jLVj5rJ4bQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, Apr 8, 2025 at 10:49 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Tue, Apr 08, 2025 at 08:47:53AM +0530, Ashutosh Bapat wrote:
> > Thanks for addressing the comment.
> >
> > In PG code, we start a multiline comment with just /* on the first
> > line and end with just */ on the last line. All the lines in-between
> > start with * . Please check other comments in the file.
> >
> > I would write a., b. c. d. on separate lines.
>
> Hmm. I don't think that grouping all these details in the same
> comment block is an improvement in this case compared to the first
> version, where it is clear which part of the calculation applies to
> what. In short, I'm OK with how things are on HEAD.
Ah! I didn't realize it was committed already.
--
Best Wishes,
Ashutosh Bapat
From | Date | Subject | |
---|---|---|---|
Next Message | Japin Li | 2025-04-08 08:29:04 | Remove unnecessary static type qualifiers |
Previous Message | Daniel Gustafsson | 2025-04-08 08:03:09 | Re: Enhancing Memory Context Statistics Reporting |