Re: Enhancing Memory Context Statistics Reporting

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Rahila Syed <rahilasyed90(at)gmail(dot)com>
Cc: Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Enhancing Memory Context Statistics Reporting
Date: 2025-04-08 08:03:09
Message-ID: F12013F0-F54F-4C3D-92C5-76F8AE944CED@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 8 Apr 2025, at 07:40, Rahila Syed <rahilasyed90(at)gmail(dot)com> wrote:

>
>> > Renamed both to use MemoryContextReporting* namespace, which leaves
>> > MemoryContextReportingBackendState at an unwieldly long name. I'm running out
>> > of ideas on how to improve and it does make purpose quite explicit at least.
>>
>> How about
>>
>> MemoryContextReportingBackendState -> MemoryStatsBackendState
>> MemoryContextReportingId -> MemoryStatsContextId
>> MemoryContextReportingSharedState -> MemoryStatsCtl
>> MemoryContextReportingStatsEntry -> MemoryStatsEntry
>
> Fixed accordingly.

That's much better, thanks.

There was a bug in the shmem init function which caused it to fail on Windows,
the attached fixes that.

--
Daniel Gustafsson

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Ashutosh Bapat 2025-04-08 08:26:46 Re: [PATCH] clarify palloc comment on quote_literal_cstr
Previous Message Aya Iwata (Fujitsu) 2025-04-08 07:41:38 RE: [WIP]Vertical Clustered Index (columnar store extension) - take2