Re: shared-memory based stats collector

From: Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>
To: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Cc: Andres Freund <andres(at)anarazel(dot)de>, melanieplageman(at)gmail(dot)com, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>
Subject: Re: shared-memory based stats collector
Date: 2022-04-08 11:49:48
Message-ID: CAEudQArm=JW+C3DiYcHiToafcktYyxOCP+LLS07e3f8QgX0BYw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

Per Coverity.

pgstat_reset_entry does not check if lock it was really blocked.
I think if shared_stat_reset_contents is called without lock,
is it an issue not?

regards,

Ranier Vilela

Attachment Content-Type Size
0001-avoid-reset-stats-without-lock.patch application/octet-stream 687 bytes

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Magnus Hagander 2022-04-08 11:58:21 Re: PROXY protocol support
Previous Message Magnus Hagander 2022-04-08 11:47:20 Re: Expose JIT counters/timing in pg_stat_statements