Re: shared-memory based stats collector

From: Andres Freund <andres(at)anarazel(dot)de>
To: Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Cc: melanieplageman(at)gmail(dot)com, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>
Subject: Re: shared-memory based stats collector
Date: 2022-04-08 15:59:52
Message-ID: 4E38674B-9CAC-4912-9120-59E3C6560838@anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On April 8, 2022 4:49:48 AM PDT, Ranier Vilela <ranier(dot)vf(at)gmail(dot)com> wrote:
>Hi,
>
>Per Coverity.
>
>pgstat_reset_entry does not check if lock it was really blocked.
>I think if shared_stat_reset_contents is called without lock,
>is it an issue not?

I don't think so - the nowait parameter is say to false, so the lock acquisition is blocking.

Andres

--
Sent from my Android device with K-9 Mail. Please excuse my brevity.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2022-04-08 16:01:22 Re: Temporary file access API
Previous Message Robert Haas 2022-04-08 15:52:20 Re: Atomic rename feature for Windows.