Re: Improve cleaning files on Postgres crashes

From: Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Improve cleaning files on Postgres crashes
Date: 2025-02-18 16:29:45
Message-ID: CAEudQArC5S6Sy4+Qs_87v3LpDd9ebwLB36zBwB+0r+TiO2hsvg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Em ter., 18 de fev. de 2025 13:21, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> escreveu:

> Ranier Vilela <ranier(dot)vf(at)gmail(dot)com> writes:
> > There are some reports that Postgres does not handle correctly cleaning
> the
> > files used when it crashes. [1]
> > I think that function *fcloseall* can help a little bit.
> > Mainly on Windows.
>
Thanks for answear Tom.

I doubt that this is a good thing to try to do during a panic exit.
> In the first place, we don't know to what extent the process's
> internal data structures may be corrupted, possibly causing
> fcloseall itself to malfunction.

Well, I put after fflush(NULL), so if data structures are corrupted, fflush
will fail in any way.

In the second place, we might
> wish to have a look at those temp files for debugging purposes.
>
On dev/debug are great, but on production, where disk spaces cost money, I
think that a good idea.

Maybe guarded by ifdefs?

Best regards,
Ranier Vilela

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2025-02-18 16:30:02 Re: Clarification on Role Access Rights to Table Indexes
Previous Message Robert Haas 2025-02-18 16:21:33 Re: Clarification on Role Access Rights to Table Indexes