Re: Simplify the logic a bit (src/bin/scripts/reindexdb.c)

Em seg., 17 de mar. de 2025 às 16:17, Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>
escreveu:

> Em sex., 7 de mar. de 2025 às 16:14, Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>
> escreveu:
>
>>
>>
>> Em sex., 7 de mar. de 2025 às 16:01, Álvaro Herrera <
>> alvherre(at)alvh(dot)no-ip(dot)org> escreveu:
>>
>>> On 2025-Mar-07, Álvaro Herrera wrote:
>>>
>>> > Anyway, my version of this is attached. It fixes the problems with
>>> your
>>> > patch, but not Orlov's fundamental bug.
>>>
>>> And of course I forgot to actually attach the patch. Good grief.
>>>
>> Test with your v4 patch, on Windows 64 bits.
>>
> Rebased against 682c5be
> <https://github.com/postgres/postgres/commit/682c5be25c28192c56e9d5e2a9ca14673a2fcf4b>
>
Coverity reported two new warnings regarding reindexdb.

CID 1593911: (#1 of 1): Dereference after null check (FORWARD_NULL)
49. var_deref_op: Dereferencing null pointer indices_tables_cell.

CID 1593910: (#1 of 1): Explicit null dereferenced (FORWARD_NULL)
9. var_deref_op: Dereferencing null pointer process_list.

Attached is an attempt to fix.

best regards,
Ranier Vilela