Re: Simplify the logic a bit (src/bin/scripts/reindexdb.c)

From: Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>
To: Álvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Alexander Korotkov <akorotkov(at)postgresql(dot)org>, Maxim Orlov <orlovmg(at)gmail(dot)com>, Svetlana Derevyanko <s(dot)derevyanko(at)postgrespro(dot)ru>
Subject: Re: Simplify the logic a bit (src/bin/scripts/reindexdb.c)
Date: 2025-03-17 19:17:23
Message-ID: CAEudQApLqtdfnSLR6hMgKpva-O+ZuhaYuVf5v9iMxQykda8pOw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Em sex., 7 de mar. de 2025 às 16:14, Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>
escreveu:

>
>
> Em sex., 7 de mar. de 2025 às 16:01, Álvaro Herrera <
> alvherre(at)alvh(dot)no-ip(dot)org> escreveu:
>
>> On 2025-Mar-07, Álvaro Herrera wrote:
>>
>> > Anyway, my version of this is attached. It fixes the problems with your
>> > patch, but not Orlov's fundamental bug.
>>
>> And of course I forgot to actually attach the patch. Good grief.
>>
> Test with your v4 patch, on Windows 64 bits.
>
Rebased against 682c5be
<https://github.com/postgres/postgres/commit/682c5be25c28192c56e9d5e2a9ca14673a2fcf4b>

Tests:
reindexdb -U postgres -d postgres -j4 --echo -i foo1 -i foo2 -i bar1 -i
bar2 -i baz1 -i baz2 -i baz3 -i baz4 | grep REINDEX
File STDIN:
REINDEX INDEX public.baz4;
REINDEX INDEX public.baz1;
REINDEX INDEX public.baz2;
REINDEX INDEX public.baz3;
REINDEX INDEX public.foo1;
REINDEX INDEX public.foo2;
REINDEX INDEX public.bar1;
REINDEX INDEX public.bar2;

best regards,
Ranier Vilela

Attachment Content-Type Size
v5-try-but-fail-to-unbreak-reindexdb.patch application/octet-stream 14.0 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2025-03-17 19:27:11 Re: optimize file transfer in pg_upgrade
Previous Message Álvaro Herrera 2025-03-17 19:14:16 Re: pg_stat_statements and "IN" conditions