Windows sockets (select missing events?)

From: Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>
To: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Windows sockets (select missing events?)
Date: 2023-12-28 17:45:40
Message-ID: CAEudQAqjqkXXsjdKpmi=ry+JCfaKrFJO9NF1bP5CrtvZwh0uHg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

The type of field fd_count is defined in winsock.h:
typedef unsigned int u_int;

So in the struct fd_set,
the field fd_count is unsigned int.

The pgwin32_select function has loops that use *int* as indices.

Question: in Windows, the socket select function isn't missing some events?

If not, It would be a good prevention practice, using the correct type,
right?

Patch attached.

best regards,
Ranier Vilela

Attachment Content-Type Size
001-fix-socket-select-events.patch application/octet-stream 545 bytes

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alexander Lakhin 2023-12-28 19:00:00 Re: broken master regress tests
Previous Message Bruce Momjian 2023-12-28 17:37:16 Re: Statistics Import and Export