| From: | Ranier Vilela <ranier(dot)vf(at)gmail(dot)com> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | Mahendra Singh Thalor <mahi6run(at)gmail(dot)com>, Álvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, jian he <jian(dot)universality(at)gmail(dot)com>, Srinath Reddy <srinath2133(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Non-text mode for pg_dumpall |
| Date: | 2025-04-10 23:23:40 |
| Message-ID: | CAEudQApnevrfG=GM5YZOfrHm4PmK+oXmz+eA=3Pv8tC2oZRoPg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Em qui., 10 de abr. de 2025 20:09, Andrew Dunstan <andrew(at)dunslane(dot)net>
escreveu:
>
> On 2025-04-10 Th 5:45 PM, Ranier Vilela wrote:
>
>
> Em qui., 10 de abr. de 2025 às 15:58, Andrew Dunstan <andrew(at)dunslane(dot)net>
> escreveu:
>
>>
>> On 2025-04-10 Th 2:38 PM, Ranier Vilela wrote:
>>
>>
>>>
>>> Thanks. I have pushed these now with a few further small tweaks.
>>>
>> Sorry if it is not the right place.
>> Coverity has another resource leak alert.
>>
>> trivial patch attached.
>>
>>
>>
>>
>> Thanks for checking. Pushed.
>>
> Andew, I think that the commit wasn't very correct.
> Now the variable *q* is being destroyed inside the loop.
>
> The patch was destroying the variable *q* (stringinfo),
> after the loop while.
>
>
>
> Yes, you're right. Must be blind. Fixed.
>
Thanks Andrew.
best regards,
Ranier Vilela
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Sami Imseih | 2025-04-10 23:45:36 | Re: stats.sql fails during installcheck on mac |
| Previous Message | Andrew Dunstan | 2025-04-10 23:08:57 | Re: Non-text mode for pg_dumpall |