| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Ranier Vilela <ranier(dot)vf(at)gmail(dot)com> |
| Cc: | Mahendra Singh Thalor <mahi6run(at)gmail(dot)com>, Álvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, jian he <jian(dot)universality(at)gmail(dot)com>, Srinath Reddy <srinath2133(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Non-text mode for pg_dumpall |
| Date: | 2025-04-10 23:08:57 |
| Message-ID: | 8354938e-6400-4dc1-b783-474886669250@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2025-04-10 Th 5:45 PM, Ranier Vilela wrote:
>
> Em qui., 10 de abr. de 2025 às 15:58, Andrew Dunstan
> <andrew(at)dunslane(dot)net> escreveu:
>
>
> On 2025-04-10 Th 2:38 PM, Ranier Vilela wrote:
>>
>>
>>
>> Thanks. I have pushed these now with a few further small tweaks.
>>
>> Sorry if it is not the right place.
>> Coverity has another resource leak alert.
>>
>> trivial patch attached.
>>
>>
>
>
> Thanks for checking. Pushed.
>
> Andew, I think that the commit wasn't very correct.
> Now the variable *q* is being destroyed inside the loop.
>
> The patch was destroying the variable *q* (stringinfo),
> after the loop while.
>
Yes, you're right. Must be blind. Fixed.
cheers
andrew
--
Andrew Dunstan
EDB:https://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ranier Vilela | 2025-04-10 23:23:40 | Re: Non-text mode for pg_dumpall |
| Previous Message | Matthias van de Meent | 2025-04-10 22:47:19 | Re: MergeJoin beats HashJoin in the case of multiple hash clauses |