| From: | Ranier Vilela <ranier(dot)vf(at)gmail(dot)com> |
|---|---|
| To: | David Rowley <dgrowleyml(at)gmail(dot)com> |
| Cc: | Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Fix possible bogus array out of bonds (src/backend/access/brin/brin_minmax_multi.c) |
| Date: | 2022-09-06 01:52:34 |
| Message-ID: | CAEudQApjZ5FPobhssXj2=+8TPK-BnWqiSvdj4sW3sUdKHc1sBg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Em seg., 5 de set. de 2022 às 22:29, David Rowley <dgrowleyml(at)gmail(dot)com>
escreveu:
> On Tue, 6 Sept 2022 at 06:07, Ranier Vilela <ranier(dot)vf(at)gmail(dot)com> wrote:
> > I did a search and found a few more places.
> > v1 attached.
>
> Thanks. I've done a bit more looking and found a few more places that
> we can improve and I've pushed the result.
>
Thanks.
>
> It feels like it would be good if we had a way to detect a few of
> these issues much earlier than we are currently. There's been a long
> series of commits fixing up this sort of thing. If we had a tool to
> parse the .c files and look for things like a function call to
> appendPQExpBuffer() and appendStringInfo() with only 2 parameters (i.e
> no va_arg arguments).
>
StaticAssert could check va_arg no?
regards,
Ranier Vilela
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2022-09-06 02:02:42 | Re: Fix possible bogus array out of bonds (src/backend/access/brin/brin_minmax_multi.c) |
| Previous Message | Tom Lane | 2022-09-06 01:51:38 | Re: pg15b3: recovery fails with wal prefetch enabled |