| From: | David Rowley <dgrowleyml(at)gmail(dot)com> |
|---|---|
| To: | Ranier Vilela <ranier(dot)vf(at)gmail(dot)com> |
| Cc: | Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Fix possible bogus array out of bonds (src/backend/access/brin/brin_minmax_multi.c) |
| Date: | 2022-09-06 02:02:42 |
| Message-ID: | CAApHDvpez9me=6gFo82p+j_GY0k5SDkFhtq4qvPXA63a=HpQ9A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, 6 Sept 2022 at 13:52, Ranier Vilela <ranier(dot)vf(at)gmail(dot)com> wrote:
>
> Em seg., 5 de set. de 2022 às 22:29, David Rowley <dgrowleyml(at)gmail(dot)com> escreveu:
>> It feels like it would be good if we had a way to detect a few of
>> these issues much earlier than we are currently. There's been a long
>> series of commits fixing up this sort of thing. If we had a tool to
>> parse the .c files and look for things like a function call to
>> appendPQExpBuffer() and appendStringInfo() with only 2 parameters (i.e
>> no va_arg arguments).
>
> StaticAssert could check va_arg no?
I'm not sure exactly what you have in mind. If you think you have a
way to make that work, it would be good to see a patch with it.
David
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2022-09-06 02:03:52 | Re: pg15b3: recovery fails with wal prefetch enabled |
| Previous Message | Ranier Vilela | 2022-09-06 01:52:34 | Re: Fix possible bogus array out of bonds (src/backend/access/brin/brin_minmax_multi.c) |