From: | Ranier Vilela <ranier(dot)vf(at)gmail(dot)com> |
---|---|
To: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
Cc: | Justin Pryzby <pryzby(at)telsasoft(dot)com>, David Rowley <dgrowleyml(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Avoid unecessary MemSet call (src/backend/utils/cache/relcache.c) |
Date: | 2022-07-16 19:54:56 |
Message-ID: | CAEudQAp9Eh+FOUqfb6zgkvsihMBe_0fd0OLFaaqqicD7MTmPHg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Em sáb, 16 de jul de 2022 2:58 AM, Peter Eisentraut <
peter(dot)eisentraut(at)enterprisedb(dot)com> escreveu:
> On 11.07.22 21:06, Ranier Vilela wrote:
> > Em qui., 7 de jul. de 2022 às 14:01, Ranier Vilela <ranier(dot)vf(at)gmail(dot)com
> > <mailto:ranier(dot)vf(at)gmail(dot)com>> escreveu:
> >
> > Attached the v1 of your patch.
> > I think that all is safe to switch MemSet by {0}.
> >
> > Here the rebased patch v2, against latest head.
>
> I have committed my patch with Álvaro's comments addressed
>
I see.
It's annoing that old compiler (gcc 4.7.2) don't handle this style.
> Your patch appears to add in changes that are either arguably out of
> scope or would need further review (e.g., changing memset() calls,
> changing the scope of some variables, changing places that need to worry
> about padding bits). Please submit separate patches for those, and we
> can continue the analysis.
>
Sure.
Regards
Ranier Vilela
>
From | Date | Subject | |
---|---|---|---|
Next Message | Andres Freund | 2022-07-16 20:17:50 | Re: Use -fvisibility=hidden for shared libraries |
Previous Message | Spyridon Dimitrios Agathos | 2022-07-16 18:38:14 | Re: Bug: Reading from single byte character column type may cause out of bounds memory reads. |