Re: Avoid unecessary MemSet call (src/backend/utils/cache/relcache.c)

From: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
To: Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>
Cc: Justin Pryzby <pryzby(at)telsasoft(dot)com>, David Rowley <dgrowleyml(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Avoid unecessary MemSet call (src/backend/utils/cache/relcache.c)
Date: 2022-07-16 06:58:10
Message-ID: 91093c8c-8105-6902-1876-b48383efd973@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 11.07.22 21:06, Ranier Vilela wrote:
> Em qui., 7 de jul. de 2022 às 14:01, Ranier Vilela <ranier(dot)vf(at)gmail(dot)com
> <mailto:ranier(dot)vf(at)gmail(dot)com>> escreveu:
>
> Attached the v1 of your patch.
> I think that all is safe to switch MemSet by {0}.
>
> Here the rebased patch v2, against latest head.

I have committed my patch with Álvaro's comments addressed.

Your patch appears to add in changes that are either arguably out of
scope or would need further review (e.g., changing memset() calls,
changing the scope of some variables, changing places that need to worry
about padding bits). Please submit separate patches for those, and we
can continue the analysis.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2022-07-16 08:31:29 Re: Moving RwF patches to a new CF
Previous Message John Naylor 2022-07-16 05:43:39 Re: Improving scalability of Parallel Bitmap Heap/Index Scan