From: | Tommy Pavlicek <tommypav122(at)gmail(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com> |
Subject: | Re: [PATCH] Extend ALTER OPERATOR to support adding commutator, negator, hashes, and merges |
Date: | 2023-07-02 14:42:53 |
Message-ID: | CAEhP-W-bY5CTXgrsH_J=NyKJpqMOgUPqMQ9-oTtx2N+zND1ZuA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Fri, Jun 23, 2023 at 12:21 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> Tommy Pavlicek <tommypav122(at)gmail(dot)com> writes:
> > I've added a single patch here: https://commitfest.postgresql.org/43/4389/
>
> > It wasn't obvious whether I should create a second commitfest entry
> > because I've included 2 patches so I've just done 1 to begin with. On
> > that note, is it preferred here to split patches of this size into
> > separate patches, and if so, additionally, separate threads?
>
> No, our commitfest infrastructure is unable to deal with patches that have
> interdependencies unless they're presented in a single email. So just use
> one thread, and be sure to attach all the patches each time.
>
> (BTW, while you seem to have gotten away with it so far, it's usually
> advisable to name the patch files like 0001-foo.patch, 0002-bar.patch,
> etc, to make sure the cfbot understands what order to apply them in.)
>
> regards, tom lane
Thanks.
I've attached a new version of the ALTER OPERATOR patch that allows
no-ops. It should be ready to review now.
Attachment | Content-Type | Size |
---|---|---|
0001-create_op_fixes_v1.patch | application/octet-stream | 15.9 KB |
0002-alter_op_v2.patch | application/octet-stream | 29.5 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | vignesh C | 2023-07-02 15:12:06 | Improve tab completion for ALTER DEFAULT PRIVILEGE and ALTER TABLE |
Previous Message | Tomas Vondra | 2023-07-02 13:50:47 | Re: Fdw batch insert error out when set batch_size > 65535 |