Re: Broken API specification for walrcv_receive

From: Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Broken API specification for walrcv_receive
Date: 2016-04-14 21:46:18
Message-ID: CAEepm=3SrkRm8fw2VM2=QC4OdNW8LyzN2=yECmQ_Kff_X=JNyg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Apr 15, 2016 at 4:28 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> I noticed thanks to a buildfarm warning that replication/walreceiver.h
> now declares the walrcv_receive hook as
>
> typedef int (*walrcv_receive_type) (char **buffer, int *wait_fd);
>
> This is flat out wrong, isn't it? wait_fd needs to be of type pgsocket,
> which is a different width from "int" on Windows.

Right, I see. Thanks for fixing that.

--
Thomas Munro
http://www.enterprisedb.com

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Geoghegan 2016-04-14 23:03:51 Obsolete comment within fmgr.c
Previous Message Alexander Korotkov 2016-04-14 20:29:36 Re: Move PinBuffer and UnpinBuffer to atomics