Broken API specification for walrcv_receive

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-hackers(at)postgreSQL(dot)org
Subject: Broken API specification for walrcv_receive
Date: 2016-04-14 16:28:43
Message-ID: 30372.1460651323@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I noticed thanks to a buildfarm warning that replication/walreceiver.h
now declares the walrcv_receive hook as

typedef int (*walrcv_receive_type) (char **buffer, int *wait_fd);

This is flat out wrong, isn't it? wait_fd needs to be of type pgsocket,
which is a different width from "int" on Windows.

regards, tom lane

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jim Nasby 2016-04-14 16:42:52 Re: Refactor pg_dump as a library?
Previous Message Andres Freund 2016-04-14 16:11:01 Re: Suspicious behaviour on applying XLOG_HEAP2_VISIBLE.