Re: pgsql: Fix another instance of unsafe coding for shm_toc_lookup failure

On Sat, Feb 3, 2018 at 3:08 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> writes:
>> However, it's not surprising that you drew the
>> opposite conclusion (ie that it might in fact not be in the TOC),
>> since the shm space is really only necessary for EXPLAIN ANALYZE.
>> Perhaps I should make it skip setting up this shm stuff if
>> !node->ss.ps.instrument, just like the equivalent Sort node code. I
>> will look into that on Monday.
>
> OK. Please send in a patch to either do that or switch this call to use
> noError = false. Or possibly both: shouldn't there be some other signal
> path that tells the worker whether instrumentation is needed? I'll
> leave it alone pending your investigation.

Here's a patch do to both.

--
Thomas Munro
http://www.enterprisedb.com