Re: pgsql: Fix another instance of unsafe coding for shm_toc_lookup failure

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>
Cc: pgsql-committers <pgsql-committers(at)postgresql(dot)org>
Subject: Re: pgsql: Fix another instance of unsafe coding for shm_toc_lookup failure
Date: 2018-02-05 03:15:29
Message-ID: 6686.1517800529@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> writes:
> On Sat, Feb 3, 2018 at 3:08 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> OK. Please send in a patch to either do that or switch this call to use
>> noError = false. Or possibly both: shouldn't there be some other signal
>> path that tells the worker whether instrumentation is needed? I'll
>> leave it alone pending your investigation.

> Here's a patch do to both.

LGTM, pushed.

regards, tom lane

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2018-02-05 15:37:45 pgsql: Fix RelationBuildPartitionKey's processing of partition key expr
Previous Message Tom Lane 2018-02-05 03:15:06 pgsql: Skip setting up shared instrumentation for Hash node if not need