Re: [PATCH] fix for C4141 warning on MSVC

On Wed, Jan 24, 2018 at 1:42 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> writes:
>> On Wed, Jan 24, 2018 at 1:16 PM, Michail Nikolaev
>> <michail(dot)nikolaev(at)gmail(dot)com> wrote:
>>> Just very small fix for C4141 warning
>
>> Thanks. This is similar to the fix I proposed over here:
>> https://www.postgresql.org/message-id/CAEepm%3D2iTKvbebiK3CdoczQk4_FfDt1EeU4c%2BnGE340JH7gQ0g%40mail.gmail.com
>
>> Perhaps we should combine these?
>
> +1. The previous thread seems to have died off with nothing happening,
> but we still have those issues to resolve. I like the idea of making
> the macro be a direct drop-in substitute for "inline" rather than
> something you use in addition to "inline". And if we do that, it
> definitely should expand to plain "inline" if we have no other idea.

Here's one like that.

--
Thomas Munro
http://www.enterprisedb.com