| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> |
| Cc: | Michail Nikolaev <michail(dot)nikolaev(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] fix for C4141 warning on MSVC |
| Date: | 2018-01-24 00:42:25 |
| Message-ID: | 22599.1516754545@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> writes:
> On Wed, Jan 24, 2018 at 1:16 PM, Michail Nikolaev
> <michail(dot)nikolaev(at)gmail(dot)com> wrote:
>> Just very small fix for C4141 warning
> Thanks. This is similar to the fix I proposed over here:
> https://www.postgresql.org/message-id/CAEepm%3D2iTKvbebiK3CdoczQk4_FfDt1EeU4c%2BnGE340JH7gQ0g%40mail.gmail.com
> Perhaps we should combine these?
+1. The previous thread seems to have died off with nothing happening,
but we still have those issues to resolve. I like the idea of making
the macro be a direct drop-in substitute for "inline" rather than
something you use in addition to "inline". And if we do that, it
definitely should expand to plain "inline" if we have no other idea.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2018-01-24 00:59:24 | Re: documentation is now XML |
| Previous Message | Bruce Momjian | 2018-01-24 00:34:38 | Re: Missing wal_receiver_status_interval in Subscribers section |