| From: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> |
|---|---|
| To: | Adrien Nayrat <adrien(dot)nayrat(at)anayrat(dot)info> |
| Cc: | Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, vik(dot)fearing(at)2ndquadrant(dot)com, Robert Haas <robertmhaas(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: New GUC to sample log queries |
| Date: | 2018-11-25 23:40:21 |
| Message-ID: | CAEepm=1KmyiHiXUdMKwkCXfwDD45fRAO5YuJ7zhSNHSjFUQseg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Nov 21, 2018 at 9:06 PM Adrien Nayrat
<adrien(dot)nayrat(at)anayrat(dot)info> wrote:
> Thanks for your comments. Here is the updated patch. I fixed a warning for
> missing parentheses in this expression:
> if ((exceeded && in_sample) || log_duration)
Hi Adrien,
GCC 4.8 says:
guc.c:3328:3: error: initialization makes integer from pointer without
a cast [-Werror]
},
^
guc.c:3328:3: error: (near initialization for
‘ConfigureNamesReal[19].gen.flags’) [-Werror]
--
Thomas Munro
http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Fetter | 2018-11-25 23:49:29 | Re: Constraint documentation |
| Previous Message | David Fetter | 2018-11-25 23:32:30 | Re: [HACKERS] Time to change pg_regress diffs to unified by default? |