From: | David Fetter <david(at)fetter(dot)org> |
---|---|
To: | Patrick Francelle <patrick(at)francelle(dot)name> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Pantelis Theodosiou <ypercube(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Lætitia Avrot <laetitia(dot)avrot(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Brad DeJong <bpd0018(at)gmail(dot)com>, Vik Fearing <vik(dot)fearing(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Constraint documentation |
Date: | 2018-11-25 23:49:29 |
Message-ID: | 20181125234928.GE4030@fetter.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thu, Nov 22, 2018 at 03:16:11PM +0100, Patrick Francelle wrote:
> On 11/15/18 00:02, Tom Lane wrote:
> > I think this could be improved some more. Perhaps something like this
> > (I've not bothered with markup...)
> >
> > This is a little verbose maybe, but as the text stands, it sounds like
> > using a trigger is enough to solve all the consistency problems that
> > a cross-row CHECK has. Which it's not of course.
>
> Thank you for the rewriting, this is much more clear and explicit that way.
>
> > I'm also wondering whether it's better to put this in the CREATE TABLE
> > reference page instead of here. While there are certainly benefits in
> > having the caveat here, I'm a bit troubled by the number of forward
> > references to concepts that are described later. OTOH, a lot of people
> > who need the warning might never see it if it's buried in the reference
> > material.
>
> To address your remark, I added a small message in the CREATE TABLE
> reference page to be more explicit about the topic, so that it would be
> a warning for the users reading the section. And then a reference to the
> CHECK constraint page where the full explanation is to be located.
>
> That way, the caveat is mentioned in both pages, but the full
> explanation is located only on a single page.
>
> Please, let me know if this is good enough or maybe if I missed
> something.
>
> Patrick Francelle
I believe that features F671 (subqueries in CHECK constraints) and
possibly F673 (reads SQL-data routine invocations in CHECK
constraints) from the standard should be referred to here.
We haven't implemented either one of them, but we might some day.
Best,
David.
--
David Fetter <david(at)fetter(dot)org> http://fetter.org/
Phone: +1 415 235 3778
Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2018-11-25 23:53:02 | pgsql: Add PGXS options to control TAP and isolation tests |
Previous Message | Thomas Munro | 2018-11-25 23:40:21 | Re: New GUC to sample log queries |