Re: Simplifying width_bucket_numeric()

From: Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>
To: Joel Jacobson <joel(at)compiler(dot)org>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Simplifying width_bucket_numeric()
Date: 2024-07-10 19:31:02
Message-ID: CAEZATCWJ83U2ebcEW5KiD83YL_aLE+n3JHUO+gyY_hYEEiq91g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, 7 Jul 2024 at 13:43, Joel Jacobson <joel(at)compiler(dot)org> wrote:
>
> > SELECT hash_array(array_agg(width_bucket(op, b1, b2, c))) FROM t;
> > -- Result not changed by patch
>
> Same hash_array on all my three machines:
>
> > SELECT sum(width_bucket(op, b1, b2, c)) FROM t;
> > Time: 3658.962 ms (00:03.659) -- HEAD
> > Time: 3089.946 ms (00:03.090) -- with patch
>
> Significant improvement on all my three machines:
>

Thanks for testing. I have committed this now.

(I also realised that the "reversed_bounds" code was unnecessary,
since the only effect was to negate both inputs to div_var(), so the
signs cancel out.)

Regards,
Dean

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Nathan Bossart 2024-07-10 19:32:06 Re: pg_maintain and USAGE privilege on schema
Previous Message Jeff Davis 2024-07-10 19:29:00 Re: pg_maintain and USAGE privilege on schema