| From: | Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> |
|---|---|
| To: | David Rowley <dgrowleyml(at)gmail(dot)com> |
| Cc: | PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Minor fixes for couple some comments around MERGE RETURNING |
| Date: | 2024-06-04 08:39:05 |
| Message-ID: | CAEZATCUfJUE0sYWMHP-6X=_PFzZ-m4AX4V98B-yCSRzA6A-nEg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, 23 May 2024 at 04:26, David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
>
> On Sun, 19 May 2024 at 15:20, David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
> >
> > I noticed that PlannedStmt.hasReturning and hasModifyingCTE have an
> > outdated comment now that MERGE supports RETURNING (per commit
> > c649fa24a)
> >
> > i.e. these two:
> >
> > > bool hasReturning; /* is it insert|update|delete RETURNING? */
> >
> > > bool hasModifyingCTE; /* has insert|update|delete in WITH? */
>
> I've pushed the fix for that.
>
Thanks for taking care of that.
I found another couple of similar comments that also needed updating,
so I've pushed a fix for them too.
Regards,
Dean
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Smith | 2024-06-04 09:30:49 | Re: Pgoutput not capturing the generated columns |
| Previous Message | Kyotaro Horiguchi | 2024-06-04 07:44:09 | Re: [PATCH]A minor improvement to the error-report in SimpleLruWriteAll() |