| From: | Junwang Zhao <zhjwpku(at)gmail(dot)com> |
|---|---|
| To: | "Andrey M(dot) Borodin" <x4mmm(at)yandex-team(dot)ru> |
| Cc: | Melanie Plageman <melanieplageman(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Subject: | Re: Using read_stream in index vacuum |
| Date: | 2024-10-23 14:37:51 |
| Message-ID: | CAEG8a3KCgh72iW5aMLEKGhrKzN9dQCHCJgL8KDz0ja4nvS5Xgg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Oct 23, 2024 at 9:32 PM Andrey M. Borodin <x4mmm(at)yandex-team(dot)ru> wrote:
>
>
>
> > On 22 Oct 2024, at 16:42, Melanie Plageman <melanieplageman(at)gmail(dot)com> wrote:
> >
> > Ah, right, the callback might return InvalidBlockNumber far before
> > we've actually read (and vacuumed) the blocks it is specifying.
>
> I've discussed the issue with Thomas on PGConf.eu and he proposed to use stream reset.
> PFA v3.
Yeah, read_stream_reset fits better.
The patch LGTM, thanks.
>
>
> Best regards, Andrey Borodin.
--
Regards
Junwang Zhao
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2024-10-23 14:46:56 | Re: use a non-locking initial test in TAS_SPIN on AArch64 |
| Previous Message | Junwang Zhao | 2024-10-23 14:28:05 | Re: general purpose array_sort |