From: | Junwang Zhao <zhjwpku(at)gmail(dot)com> |
---|---|
To: | Erikjan Rijkers <er(at)xs4all(dot)nl> |
Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: [doc] fix a potential grammer mistake |
Date: | 2022-08-03 08:38:01 |
Message-ID: | CAEG8a3+nRG4b96rgKguzg7upkQsmvTTGCBhnJfnFXyPy3cbhdA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
yeah, not a grammar mistake at all, "were" should be used here, thanks
for pointing that out ;)
On Wed, Aug 3, 2022 at 4:27 PM Erikjan Rijkers <er(at)xs4all(dot)nl> wrote:
>
> Op 03-08-2022 om 10:10 schreef Junwang Zhao:
> > I think in the following sentence, were should be replaced with have,
> > what do you think?
> >
> > ```
> > /*
> > - * We were just issued a SAVEPOINT inside a
> > transaction block.
> > + * We have just issued a SAVEPOINT inside a
> > transaction block.
> > * Start a subtransaction. (DefineSavepoint already did
> > * PushTransaction, so as to have someplace to
> > put the SUBBEGIN
> > * state.)
> > ```
>
> I don't think these "were"s are wrong but arguably changing them to
> "have" helps non-native speakers (like myself), as it doesn't change the
> meaning significantly as far as I can see.
>
> 'we were issued' does reflect the perspective of the receiving code a
> bit better.
>
>
> Erik
>
--
Regards
Junwang Zhao
From | Date | Subject | |
---|---|---|---|
Next Message | Shinoda, Noriyoshi (PN Japan FSIP) | 2022-08-03 08:42:01 | RE: Improve logging when using Huge Pages |
Previous Message | Junwang Zhao | 2022-08-03 08:35:52 | Re: [doc] fix a potential grammer mistake |