| From: | Erikjan Rijkers <er(at)xs4all(dot)nl> |
|---|---|
| To: | Junwang Zhao <zhjwpku(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [doc] fix a potential grammer mistake |
| Date: | 2022-08-03 08:27:42 |
| Message-ID: | 78b49522-8a13-d90b-e2ce-be29d43cbd73@xs4all.nl |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Op 03-08-2022 om 10:10 schreef Junwang Zhao:
> I think in the following sentence, were should be replaced with have,
> what do you think?
>
> ```
> /*
> - * We were just issued a SAVEPOINT inside a
> transaction block.
> + * We have just issued a SAVEPOINT inside a
> transaction block.
> * Start a subtransaction. (DefineSavepoint already did
> * PushTransaction, so as to have someplace to
> put the SUBBEGIN
> * state.)
> ```
I don't think these "were"s are wrong but arguably changing them to
"have" helps non-native speakers (like myself), as it doesn't change the
meaning significantly as far as I can see.
'we were issued' does reflect the perspective of the receiving code a
bit better.
Erik
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Junwang Zhao | 2022-08-03 08:35:52 | Re: [doc] fix a potential grammer mistake |
| Previous Message | Daniel Gustafsson | 2022-08-03 08:23:49 | Re: [doc] fix a potential grammer mistake |