Re: PATCH: Add missing nodes to graphical explain plan

From: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: "J(dot)F(dot) Oster" <jinfroster(at)mail(dot)ru>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: PATCH: Add missing nodes to graphical explain plan
Date: 2014-11-19 20:01:44
Message-ID: CAECtzeX_-p0P+fkNNN64+DU59MLePqHA1HFiLPe6bwxOwhWfpg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers pgadmin-support

2014-11-18 17:09 GMT+01:00 Dave Page <dpage(at)pgadmin(dot)org>:

> If Guillaume is satisfied with the code enough to commit it, it can. I
> consider it a bug fix, albeit minor.
>
>
I didn't check the code. I just looked at the pics, and they feel right to
me. Pretty sure I won't have time to check the code, and commit it, before
the week-end.

On Tue, Nov 18, 2014 at 3:00 PM, J.F. Oster <jinfroster(at)mail(dot)ru> wrote:
> > Hello Dave,
> >
> > I wonder if this patch will get into 1.20...
> >
> > Wednesday, November 5, 2014, 5:25:10 PM, J.F. Oster wrote:
> >
> > JFO> Hello,
> >
> > JFO> Per recent discussion on pgadmin-support ("index only scans are not
> > JFO> shown graphically"),
> >
> > JFO>> Insert
> > JFO>> Update
> > JFO>> Delete
> > JFO>> Foreign Scan
> > JFO>> Index Only Scan
> > JFO>> BitmapAnd
> > JFO>> BitmapOr
> > JFO>> Values Scan (shows up as a Seq Scan)
> > JFO>> LockRows
> > JFO> + Merge Append.
> >
> > JFO> Please note, that besides 10 new icons there are two icons for
> > JFO> existing nodes in the attachment, Bitmap Heap Scan and Bitmap Index
> > JFO> Scan.
> > JFO> I've changed them for unity with BitmapOr, BitmapAnd, which
> hopefully
> > JFO> will result in an intuitive understanding of the concept by users.
> > ...
> >
> >
> >
> >
> > --
> > Best regards,
> > J.F.
> >
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>

--
Guillaume.
http://blog.guillaume.lelarge.info
http://www.dalibo.com

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2014-11-20 09:03:48 Re: PATCH: Add missing nodes to graphical explain plan
Previous Message Guillaume Lelarge 2014-11-19 17:42:28 Re: v1.20.0rc1 source code uploaded

Browse pgadmin-support by date

  From Date Subject
Next Message Dave Page 2014-11-20 09:03:48 Re: PATCH: Add missing nodes to graphical explain plan
Previous Message Akshay Joshi 2014-11-19 11:09:44 Re: potential invalid input field of pgAdmin New Column GUI