Re: Create option to hide WITH OIDS=FALSE, if OID is disabled

From: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
To: Robins Tharakan <tharakan(at)gmail(dot)com>
Cc: PgAdmin Hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Create option to hide WITH OIDS=FALSE, if OID is disabled
Date: 2014-11-09 08:38:11
Message-ID: CAECtzeWh0Fi__u6-NsOhqmZTuqRKO2pxtneZ7R6CEV78kggcyw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

2014-11-09 8:52 GMT+01:00 Robins Tharakan <tharakan(at)gmail(dot)com>:

> Hi,
>
> This is a ping to check if adding this minor feature is okay.
>
> When the SQL is generated in the ObjectBrowser->SQLPane (for a table), it
> adds OIDS = FALSE, by default. I think that for a while, this has been
> irrelevant (unless of course the table actually has OIDs enabled).
>
> Hope its okay to add a Check box in Options->Browser->UI Miscellaneous
> (Show if OIDS = FALSE) that allows a user to disable this part of the SQL.
>
> To confirm,
> - OIDS = TRUE would also show up, irrespective of the value of this
> check-box
> - For now, the Check-Box would be enabled by default
>
> Let me know if this isn't a great idea.
>
>
It'd be better to not have the checkbox, and rely on the value of the
default_with_oids GUC.

--
Guillaume.
http://blog.guillaume.lelarge.info
http://www.dalibo.com

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message David G Johnston 2014-11-09 18:20:04 Re: Create option to hide WITH OIDS=FALSE, if OID is disabled
Previous Message Robins Tharakan 2014-11-09 07:52:26 Create option to hide WITH OIDS=FALSE, if OID is disabled