Re: Create option to hide WITH OIDS=FALSE, if OID is disabled

Guillaume Lelarge-3 wrote
> 2014-11-09 8:52 GMT+01:00 Robins Tharakan <

> tharakan@

> >:
>
>> Hi,
>>
>> This is a ping to check if adding this minor feature is okay.
>>
>> When the SQL is generated in the ObjectBrowser->SQLPane (for a table), it
>> adds OIDS = FALSE, by default. I think that for a while, this has been
>> irrelevant (unless of course the table actually has OIDs enabled).
>>
>> Hope its okay to add a Check box in Options->Browser->UI Miscellaneous
>> (Show if OIDS = FALSE) that allows a user to disable this part of the
>> SQL.
>>
>> To confirm,
>> - OIDS = TRUE would also show up, irrespective of the value of this
>> check-box
>> - For now, the Check-Box would be enabled by default
>>
>> Let me know if this isn't a great idea.
>>
>>
> It'd be better to not have the checkbox, and rely on the value of the
> default_with_oids GUC.

IIRC this logic was recently addressed and introduced to psql and should
probably be mirrored in pgAdmin.

David J.

--
View this message in context: http://postgresql.1045698.n5.nabble.com/Create-option-to-hide-WITH-OIDS-FALSE-if-OID-is-disabled-tp5826232p5826248.html
Sent from the PostgreSQL - pgadmin hackers mailing list archive at Nabble.com.