Re: Incorrect errno used with %m for backend code

On Fri, Jun 22, 2018 at 2:44 PM, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> On Fri, Jun 22, 2018 at 01:00:45PM +0530, Ashutosh Sharma wrote:
>> It seems like in case of few system calls for e.g. write system call,
>> errno is not set even if the number of bytes written is smaller than
>> the bytes requested and for such cases we explicitly set an errno to
>> ENOSPC. Something like this,
>>
>> /*
>> * if write didn't set errno, assume problem is no disk space
>> */
>> errno = save_errno ? save_errno : ENOSPC;
>>
>> Shouldn't we do similar handling in your patch as well or please let
>> me know if i am missing something here.
>
> Yeah, I can see at least three of them in twophase.c. Let's fix those
> as well at the same time.

Okay, thanks for the confirmation. Few of them are also there in
origin.c and snapbuild.c files.

--
With Regards,
Ashutosh Sharma
EnterpriseDB:http://www.enterprisedb.com