From: | Michael Paquier <michael(at)paquier(dot)xyz> |
---|---|
To: | Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com> |
Cc: | Postgres hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Incorrect errno used with %m for backend code |
Date: | 2018-06-22 09:14:54 |
Message-ID: | 20180622091454.GA16899@paquier.xyz |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Fri, Jun 22, 2018 at 01:00:45PM +0530, Ashutosh Sharma wrote:
> It seems like in case of few system calls for e.g. write system call,
> errno is not set even if the number of bytes written is smaller than
> the bytes requested and for such cases we explicitly set an errno to
> ENOSPC. Something like this,
>
> /*
> * if write didn't set errno, assume problem is no disk space
> */
> errno = save_errno ? save_errno : ENOSPC;
>
> Shouldn't we do similar handling in your patch as well or please let
> me know if i am missing something here.
Yeah, I can see at least three of them in twophase.c. Let's fix those
as well at the same time.
--
Michael
From | Date | Subject | |
---|---|---|---|
Next Message | Amit Kapila | 2018-06-22 09:15:01 | Re: server crashed with TRAP: FailedAssertion("!(!parallel_aware || pathnode->path.parallel_safe)" |
Previous Message | Chris Travers | 2018-06-22 08:49:58 | utilities to rebuild commit logs from wal |