From: | Emre Hasegeli <emre(at)hasegeli(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | PostgreSQL Bugs <pgsql-bugs(at)postgresql(dot)org> |
Subject: | Re: Line intersection point is wrong |
Date: | 2016-06-20 21:27:13 |
Message-ID: | CAE2gYzyPkT6A55EOqAeLCXKYmWs6_g3VVEt_fLp+nw5bQziUwA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs |
> ... also, a quick review of all the LINE-related code in geo_ops.c
> says that it's just *full* of bugs. Aside from the issues already
> mentioned:
>
> line_recv fails to reject A=B=0
> line_perp can get division by zero
> silly coding in line_eq (A and B can't both be zero, no need to look at C)
> line_distance ignores l1->A, suspicious
> close_pl busted in same way as line_interpt_internal
I have tried to fix them. Patch attached.
> close_ps ignores tmp->B, suspicious
I think we better throw this one away, and implement another one using
close_pl().
Attachment | Content-Type | Size |
---|---|---|
more-line-fixes.patch | application/octet-stream | 3.4 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Emre Hasegeli | 2016-06-20 21:40:17 | Re: Line intersection point is wrong |
Previous Message | Tom Lane | 2016-06-20 19:50:27 | Re: BUG #14203: pgindent requires pg_bsd_indent 1.2, but only 1.3 available for download |