Re: BUG #14203: pgindent requires pg_bsd_indent 1.2, but only 1.3 available for download

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: sthomas(at)datawareventures(dot)com
Cc: pgsql-bugs(at)postgresql(dot)org
Subject: Re: BUG #14203: pgindent requires pg_bsd_indent 1.2, but only 1.3 available for download
Date: 2016-06-20 19:50:27
Message-ID: 13029.1466452227@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

sthomas(at)datawareventures(dot)com writes:
> I hacked pgindent to accept 1.3. This time it ran, but changed lots and lots
> of files. (I assume because pg_bsd_indent 1.3 makes different choices than
> pg_bsd_indent 1.2.)
> Does anyone know where I can find pg_bsd_indent 1.2?

I'm not sure why we're not keeping the older tarballs online, but there's
not that much difference between 1.2 and 1.3 --- see attached diff.

I think your problem may be in expecting that 9.3.x is pgindent-clean.
We don't normally re-pgindent stable branches, so unless committers are
careful to manually indent whatever they back-patch, branches will drift
away from a clean state. If you're trying to validate that you have a
non-broken build of pgindent, I'd suggest checking out the immediately
post-pgindent state from our git repo. The 9.3 run was at commit
9af4159fc.

regards, tom lane

Attachment Content-Type Size
pg_bsd_indent-1.2-1.3.diff text/x-diff 1.6 KB

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Emre Hasegeli 2016-06-20 21:27:13 Re: Line intersection point is wrong
Previous Message oscarrfp 2016-06-20 19:09:50 BUG #14204: COMPATIBILITY