Re: [pgadmin4][patch] Unit test fail on GreenPlum (#3190)

From: Joao De Almeida Pereira <jdealmeidapereira(at)pivotal(dot)io>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgadmin4][patch] Unit test fail on GreenPlum (#3190)
Date: 2018-03-11 23:22:05
Message-ID: CAE+jjamfkFYZ6P0Gp+h6UpHhuO7c3qWJfrompN-Mf=tn5Sj=9w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hello,
Can you point out an example?
Thanks

On Sat, Mar 10, 2018, 3:53 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:

> Hi
>
> On Friday, March 9, 2018, Joao De Almeida Pereira <
> jdealmeidapereira(at)pivotal(dot)io> wrote:
>
>> Hello Hackers,
>>
>> Attached you can find the patch that skip some tests and correct issues
>> on SQL that are failing when trying to connect to a GreenPlum database.
>>
>> We did this by adding a attribute to to test_json called "db_type" that
>> will carry the type of database we are running tests against.
>>
>
> Any reason we can't do that dynamically as we do with the EPAS-specific
> tests?
>
>
>>
>> When we run tests against a GreenPlum instance the configuration would
>> look like this:
>>
>> {
>> "name": "GreenPlum",
>> "comment": "GreenPlum DB",
>> "db_username": "gp",
>> "host": "localhost",
>> "db_password": "",
>> "db_port": 5433,
>> "maintenance_db": "postgres",
>> "sslmode": "prefer",
>> "tablespace_path": "",
>> "enabled": true,
>> "db_type": "gpdb"
>> }
>>
>>
>>
>>
>> Thanks
>> Joao
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2018-03-12 00:20:18 Re: [pgadmin4][patch] Unit test fail on GreenPlum (#3190)
Previous Message Dave Page 2018-03-10 20:53:13 Re: [pgadmin4][patch] Unit test fail on GreenPlum (#3190)